Open
Conversation
Signed-off-by: Neel050302 <104186890+Neel050302@users.noreply.github.com>
Neel050302
had a problem deploying
to
production
GitHub Actions
Failure
Signed-off-by: Neel050302 <104186890+Neel050302@users.noreply.github.com>
Neel050302
had a problem deploying
to
production
GitHub Actions
Failure
Neel050302
had a problem deploying
to
production
GitHub Actions
Failure
Neel050302
had a problem deploying
to
production
GitHub Actions
Failure
add github secrect Signed-off-by: Neel050302 <104186890+Neel050302@users.noreply.github.com>
Neel050302
had a problem deploying
to
production
GitHub Actions
Failure
Signed-off-by: Neel050302 <104186890+Neel050302@users.noreply.github.com>
Signed-off-by: Neel050302 <104186890+Neel050302@users.noreply.github.com>
| @@ -0,0 +1,21 @@ | |||
| provider "google" { | |||
Contributor
There was a problem hiding this comment.
what is this file? doesn't appear necessary
| - name: 'Configure GCP Region' | ||
| run: gcloud config set compute/region australia-southeast2 | ||
|
|
||
| # No need to change directory since Terraform files are in the root directory |
Contributor
There was a problem hiding this comment.
it's not a good check of the root modules if they aren't being checked
| run: gcloud config set compute/region australia-southeast2 | ||
|
|
||
| # No need to change directory since Terraform files are in the root directory | ||
| - name: Terraform Init |
Contributor
There was a problem hiding this comment.
terraform init is a good choice for a terraform ci check
| - name: Terraform Init | ||
| run: terraform init | ||
|
|
||
| - name: Terraform Format |
Contributor
There was a problem hiding this comment.
terraform format checking is a good choice for a terraform ci check
| - name: Terraform Plan | ||
| run: terraform plan -input=false | ||
|
|
||
| - name: Terraform Apply |
Contributor
There was a problem hiding this comment.
apply should not be ran as a basic terraform ci check
theraginggoblin
requested changes
Aug 24, 2024
Contributor
theraginggoblin
left a comment
theraginggoblin
left a comment
There was a problem hiding this comment.
lets have a conversation about what it should check and how it checks it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Test evidence